anchao commented on code in PR #14943: URL: https://github.com/apache/nuttx/pull/14943#discussion_r1878030434
########## drivers/note/note_driver.c: ########## @@ -1837,7 +1837,7 @@ void sched_note_filter_mode(FAR struct note_filter_named_mode_s *oldm, irqstate_t irq_mask; FAR struct note_driver_s **driver; - irq_mask = spin_lock_irqsave_wo_note(&g_note_lock); + irq_mask = spin_lock_irqsave_notrace(&g_note_lock); Review Comment: But why would you allow `trace.h` to be merged into nuttx? And the kernel code is also using similar APIs? https://github.com/apache/nuttx/blob/master/include/nuttx/trace.h https://github.com/apache/nuttx/blob/master/sched/task/task_init.c#L97  should we rename all trace to note? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
