xiaoxiang781216 commented on code in PR #14943:
URL: https://github.com/apache/nuttx/pull/14943#discussion_r1877975329
##########
drivers/note/note_driver.c:
##########
@@ -1837,7 +1837,7 @@ void sched_note_filter_mode(FAR struct
note_filter_named_mode_s *oldm,
irqstate_t irq_mask;
FAR struct note_driver_s **driver;
- irq_mask = spin_lock_irqsave_wo_note(&g_note_lock);
+ irq_mask = spin_lock_irqsave_notrace(&g_note_lock);
Review Comment:
Sorry, it isn't added by us but just follow the original code base. The
first patch comes from:
```
commit ab3fa890239399de51e5482e595a751fee249b1c
Author: Masayuki Ishikawa <masayuki.ishik...@jp.sony.com>
Date: Wed Jan 17 13:08:03 2018 +0900
SMP: Introduce spin_lock_wo_note() and spin_unlock_wo_note()
These APIs are used in sched_note.c to protect instumentation data.
The deffrence between these APIs to exsiting spin_lock() and
spin_unlock()
is that they do not perform insturumentation to avoid recursive call
when SCHED_INSTRUMENTATION_SPINLOCKS=y.
```
but `xxnote` is more consistent then `xxtrace`, since nuttx name the profile
api as `sched_note` not `trace`. If you want to change the term, please change
all places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
