xiaoxiang781216 commented on code in PR #15044: URL: https://github.com/apache/nuttx/pull/15044#discussion_r1877302265
########## drivers/timers/arch_alarm.c: ########## @@ -46,6 +46,7 @@ static FAR struct oneshot_lowerhalf_s *g_oneshot_lower; #ifndef CONFIG_SCHED_TICKLESS static clock_t g_current_tick; +static clock_t g_base_tick; Review Comment: The code shouldn't assume the timestamp start from 0. There even has an option to change the base near UINT32_MAX: https://github.com/apache/nuttx/blob/master/include/nuttx/clock.h#L227-L238 so, I suggest we fix the problem you mention for wdog if it's a real issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
