xiaoxiang781216 commented on code in PR #15073:
URL: https://github.com/apache/nuttx/pull/15073#discussion_r1873316742
##########
arch/arm/src/armv8-m/arm_tcbinfo.c:
##########
@@ -53,56 +53,6 @@ static const uint16_t g_reg_offs[] =
TCB_REG_OFF(REG_R14),
TCB_REG_OFF(REG_R15),
TCB_REG_OFF(REG_XPSR),
-
-#if 0
Review Comment:
why remove
##########
arch/arm/Kconfig:
##########
@@ -1011,6 +1012,7 @@ config ARCH_ARMV8M
select ARCH_HAVE_CPUINFO
select ARCH_HAVE_DEBUG
select ARCH_HAVE_PERF_EVENTS
+ select ARMV8M_USEBASEPRI
Review Comment:
but please merge armv7-m/armv8-m into one patch, and armv6-m to a new one.
##########
arch/arm/src/armv7-m/arm_tcbinfo.c:
##########
@@ -53,56 +53,6 @@ static const uint16_t g_reg_offs[] =
TCB_REG_OFF(REG_R14),
TCB_REG_OFF(REG_R15),
TCB_REG_OFF(REG_XPSR),
-
-#if 0
Review Comment:
why remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
