xiaoxiang781216 commented on code in PR #15073: URL: https://github.com/apache/nuttx/pull/15073#discussion_r1872956055
########## arch/arm/Kconfig: ########## @@ -1011,6 +1012,7 @@ config ARCH_ARMV8M select ARCH_HAVE_CPUINFO select ARCH_HAVE_DEBUG select ARCH_HAVE_PERF_EVENTS + select ARMV8M_USEBASEPRI Review Comment: Yes, it's better to remove ARMVxM_USEBASEPRI from Kconfig and always use PRIMASK, which simplify the code and boost performance. I already saw many developers who don't deeply understand cortex-m architecture use the wrong option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org