xiaoxiang781216 commented on code in PR #14901:
URL: https://github.com/apache/nuttx/pull/14901#discussion_r1853409243
##########
fs/littlefs/lfs_vfs.c:
##########
@@ -816,16 +834,31 @@ static int littlefs_fchstat(FAR const struct file *filep,
inode = filep->f_inode;
fs = inode->i_private;
+ path = lib_get_pathbuffer();
+ if (path == NULL)
+ {
+ return -ENOMEM;
+ }
+
/* Call LFS to get file size */
+ ret = littlefs_convert_result(lfs_file_path(&fs->lfs, &priv->file, path,
Review Comment:
> well, i have even suggested an alternative way to implement it months ago.
([#11724
(comment)](https://github.com/apache/nuttx/pull/11724#issuecomment-2116644633))
are you suggesting it's my responsibility to actually implement it? why? it's
up to the people who added the code, not me, IMO.
Yes, since this version is built and tested by ci for a long time ago, and
not only used by Xiaomi, but other community member. If you want to use another
version of littlefs, it's your responsibility to adapter the mainline code to
work with that version. The simplest change is:
1. support download the different littlefs version
2. Skip the patch and related function if the version mismatch
>
> i can understand the ability to use the other version of littlefs is not
important for some people. but for me it's more important than these features.
Yes, the different team and company has the different interesting. The
community version needs more work to satisfy all party.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
