yamt commented on code in PR #14901:
URL: https://github.com/apache/nuttx/pull/14901#discussion_r1853366730
##########
fs/littlefs/lfs_vfs.c:
##########
@@ -816,16 +834,31 @@ static int littlefs_fchstat(FAR const struct file *filep,
inode = filep->f_inode;
fs = inode->i_private;
+ path = lib_get_pathbuffer();
+ if (path == NULL)
+ {
+ return -ENOMEM;
+ }
+
/* Call LFS to get file size */
+ ret = littlefs_convert_result(lfs_file_path(&fs->lfs, &priv->file, path,
Review Comment:
as you know, unfortunately lfs_file_path is another local patch which is not
likely accepted by the upstream.
IMO, we should eventually remove the patch as well.
(for other reviewers who don't remember the context; see the discussion in
https://github.com/littlefs-project/littlefs/pull/976)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
