nuttxpr commented on PR #14885: URL: https://github.com/apache/nuttx/pull/14885#issuecomment-2489967818
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** fully meet the NuttX requirements as presented. While it provides a summary of the changes, it lacks crucial details in the Impact and Testing sections. Here's a breakdown: **Summary:** While it mentions the *what*, it lacks the *why* and *how*. It needs to explain the rationale behind adding KASAN support and the specific modifications made to the link process. For example, *why* is KASAN support being added? Is it to address a specific memory issue or for general robustness? *How* does modifying the link process enable cross-border detection? What specific changes were made? A related issue number would also be helpful if one exists. **Impact:** This section is entirely incomplete. All points need to be addressed. KASAN will almost certainly have an impact on build size and potentially performance. It might also affect compatibility with existing code. These potential impacts need to be documented. Does enabling KASAN require any specific configuration options? Will users need to adapt their code? Does it introduce any security considerations? These questions must be answered. **Testing:** This section is also incomplete. It needs to specify the host operating system, CPU architecture, compiler version, and target architecture and board configuration used for testing. Critically, it needs to include *actual* testing logs from before and after the change, demonstrating the effectiveness of the KASAN implementation. Simply stating that changes were verified is insufficient. Concrete evidence is required. **In short, the PR needs to be significantly more detailed to meet the NuttX requirements.** It needs to provide a comprehensive explanation of the changes, their impact, and thorough testing results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
