nuttxpr commented on PR #14761: URL: https://github.com/apache/nuttx/pull/14761#issuecomment-2473018225
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. The PR is missing critical information required by the NuttX template. * **Summary:** While it mentions the original PR and revert, it lacks a clear explanation of *why* the reapplication is necessary and *how* the fix addresses the issues that led to the revert. What exactly was the fix? * **Impact:** The entire Impact section is missing. *All* fields should be addressed with either "NO" or a "YES" + explanation. This is crucial for reviewers to understand the potential consequences of the change. * **Testing:** While targets are listed, the "Testing logs before change" and "Testing logs after change" sections are empty. This makes it impossible to verify the effectiveness of the fix. What were the symptoms of the bug before, and how do the logs demonstrate that the bug is now resolved? Furthermore, mentioning "a few other unrelated local patches" raises concerns; testing should ideally be done on a clean branch to isolate the effects of the PR. Therefore, the PR in its current state does *not* meet the NuttX requirements. It needs substantial additions to be considered complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
