hujun260 commented on code in PR #14761: URL: https://github.com/apache/nuttx/pull/14761#discussion_r1839937099
########## sched/irq/irq_csection.c: ########## @@ -75,6 +75,18 @@ volatile uint8_t g_cpu_nestcount[CONFIG_SMP_NCPUS]; * Private Functions ****************************************************************************/ +static bool csection_degraded(void) Review Comment: @yamt The invocation of critical sections is still quite frequent. Previously, we removed those checks in order to enhance performance. In some specific scenarios, we can use spin_lock_irqsave to replace the critical sections or modify the business logic judgments. So far, I haven't encountered situations where such modifications are absolutely necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
