Re: [PR] Add pipeline support for nsh commandline [nuttx-apps]

[via GitHub]

JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1801561039


##########
nshlib/nsh_parse.c:
##########
@@ -1060,9 +1080,9 @@ static FAR char *nsh_cmdparm(FAR struct nsh_vtbl_s *vtbl, 
FAR char *cmdline,
 
   /* Create a unique file name using the task ID */
 
-  tmpfile = NULL;
-  ret = asprintf(&tmpfile, "%s/TMP%d.dat", CONFIG_LIBC_TMPDIR, getpid());
-  if (ret < 0 || !tmpfile)
+  ret = asprintf(&param_exec.file_out, "%s/TMP%d.dat",

Review Comment:
   @xiaoxiang781216 @GUIDINGLI 
   An issue:
   Link to `pipe2()` successfully even if `PIPES` not enabled on SIM(sim:nsh).
   It seems that it has linked to `Host:glibc:pipe2()` if `PIPES` not enabled 
(Only the link is successful, the function is abnormal):
   
   - `PIPES` disabled on SIM
   ```
   $ cat nuttx.map | grep pipe2
                   0x0000000000435060                pipe2@@GLIBC_2.9
   ```  
   
   - `PIPES` enabled on SIM  
   
   ``` 
   $ cat nuttx.map | grep pipe2
    .rela.text.pipe2
    .text.pipe2    0x00000000004da589      0x429 nuttx.rel
                   0x00000000004da589                pipe2
   ```
   
   Is this as expected?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org