Re: [PR] Add pipeline support for nsh commandline [nuttx-apps]

[via GitHub]

JianyuWang0623 commented on code in PR #2737:
URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1801539589


##########
nshlib/nsh_parse.c:
##########
@@ -1060,9 +1080,9 @@ static FAR char *nsh_cmdparm(FAR struct nsh_vtbl_s *vtbl, 
FAR char *cmdline,
 
   /* Create a unique file name using the task ID */
 
-  tmpfile = NULL;
-  ret = asprintf(&tmpfile, "%s/TMP%d.dat", CONFIG_LIBC_TMPDIR, getpid());
-  if (ret < 0 || !tmpfile)
+  ret = asprintf(&param_exec.file_out, "%s/TMP%d.dat",

Review Comment:
   > compile fail at 1126, should free param_exec.file_out
   
   `pipe2()` undefined, have add config `NSH_PIPELINE` that depends on `PIPES`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org