patacongo commented on code in PR #12885: URL: https://github.com/apache/nuttx/pull/12885#discussion_r1730409525
########## libs/libc/stdio/lib_dtoa_engine.c: ########## @@ -69,7 +83,7 @@ int __dtoa_engine(double x, FAR struct dtoa_s *dtoa, int max_digits, uint8_t flags = 0; int i; - if (__builtin_signbit(x)) + if (x < 0) Review Comment: builtins really should not be used in common code because they are compiler specific. They should be #defined or substituted with logic in include/nuttx/compiler.h to keep the common code compiler independent. Compiler independence is requires by the "Inviolables" There are several other locations where builtins are explicitly used in the code. All of these are non-portable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
