raiden00pl commented on code in PR #12885: URL: https://github.com/apache/nuttx/pull/12885#discussion_r1730279078
########## include/nuttx/can.h: ########## @@ -326,7 +326,7 @@ struct can_frame uint8_t __pad; /* padding */ uint8_t __res0; /* reserved / padding */ uint8_t __res1; /* reserved / padding */ - uint8_t data[CAN_MAX_DLEN] aligned_data(8); Review Comment: @extinguish did you test this change with any upstream SocketCan implementation ? It looks like stm32h7 and imxrt expect this data packed: https://github.com/apache/nuttx/blob/dd7ecd9aef64b967c102808a9727a68f53025ad2/arch/arm/src/stm32h7/stm32_fdcan_sock.c#L861-L862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
