xiaoxiang781216 commented on code in PR #12881: URL: https://github.com/apache/nuttx/pull/12881#discussion_r1712962284
########## arch/risc-v/src/common/riscv_macros.S: ########## @@ -362,6 +362,9 @@ REGLOAD \out, RISCV_PERCPU_HARTID(\out) #else csrr \out, CSR_MHARTID +# if defined(CONFIG_ARCH_RV_HARTID_BASE) && CONFIG_ARCH_RV_HARTID_BASE > 0 Review Comment: why not remove ARCH_RV_GLOBAL_HARTID if we skip adjust when CONFIG_ARCH_RV_HARTID_BASE equals zero? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
