yf13 commented on code in PR #12320: URL: https://github.com/apache/nuttx/pull/12320#discussion_r1623186467
########## include/nuttx/tls.h: ########## @@ -219,6 +219,7 @@ struct tls_info_s int16_t tl_cpcount; /* Nested cancellation point count */ #endif + uint16_t tl_size; /* Actual size with alignments */ Review Comment: This is the size of thread-local-storage zone, putting it in-place is straight-forward, also more flexibile. If we are sure the size is always the same for all threads, putting in `task_info_s` is also fine and saves 2 bytes per thread, but the name shall be `ta_tls_size`, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
