michallenc commented on code in PR #12382: URL: https://github.com/apache/nuttx/pull/12382#discussion_r1609889789
########## arch/arm/src/samv7/sam_lowputc.c: ########## @@ -327,14 +327,10 @@ void sam_lowsetup(void) */ # if defined(CONFIG_SAMV7_JTAG_FULL_ENABLE) -# warning CONFIG_SAMV7_JTAG_FULL_ENABLE is incompatible with CONFIG_SAMV7_USART1. -# warning The SYSIO Pin4 must be bound to PB4 to use USART1 +# error CONFIG_SAMV7_JTAG_FULL_ENABLE is incompatible with CONFIG_SAMV7_USART1. Review Comment: This should now be redundant with the same check in `sam_gpio.c`, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org