pkarashchenko commented on PR #12382: URL: https://github.com/apache/nuttx/pull/12382#issuecomment-2124385085
> Should not this be already set in https://github.com/apache/nuttx/blob/master/arch/arm/src/samv7/sam_gpio.c#L466? And just raise compile time error if both `USART1` and `CONFIG_SAMV7_JTAG_FULL_ENABLE` is set? I didn't notice the code in `sam_gpio.c` and only found https://github.com/apache/nuttx/blob/4b2b26c0b05f4c034d781a6215971e1675623486/arch/arm/src/samv7/sam_lowputc.c#L335 Indeed, maybe it is a good idea to rise an error. I've checked my config and indeed the `CONFIG_SAMV7_JTAG_FULL_ENABLE` is set in my case, so rising an error may fix the inconsistency in the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
