xiaoxiang781216 commented on PR #2270: URL: https://github.com/apache/nuttx-apps/pull/2270#issuecomment-1915951155
> @xiaoxiang781216 why rptun and rpmsg commands are implemented as NSH commands? Since rptun/rpmsg is a simple mapping to kernel rptun/rpmsg driver, just like cmd_losetup operate on /dev/loop. > I think it should be just a regular command like "pppd" or other. Yes, it could be move to apps/system, but it belong another task. > Also although it is used for test under NSH, keeping it outside will be easier to use as standalone application. Since the action of rptun/rpmsg command is very simple: 1. Parse command line argument 2. Open the node under /dev/ and call ioctl If the user disables nsh, it's simpler to call ioctl directly, instead launch the standalone application. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
