tmedicci commented on code in PR #11620: URL: https://github.com/apache/nuttx/pull/11620#discussion_r1469822741
########## arch/risc-v/src/common/espressif/Bootloader.mk: ########## @@ -1,5 +1,5 @@ ############################################################################ -# arch/risc-v/src/espressif/Bootloader.mk +# arch/risc-v/src/common/espressif/Bootloader.mk Review Comment: > if we look at the board layout which make more sense: > > ``` > ls boards/risc-v/espressif/ > common/ esp32c3-generic/ esp32c6-generic/ esp32h2-generic/ > ``` This is the current implementation. This PR is changing that too. See: `espressif` is not a chip (and `boards/<arch>` level contains `<chip>` folders). Also, there are no `esp32c3-generic` or `esp32c6-generic` boards: this level mixes board definitions with chip definitions. The correct (as proposed in this PR) would be: `nuttx/boards/risc-v/esp32h2/common` and `nuttx/boards/risc-v/esp32h2/esp32h2-devkit` at the same level. In that sense, if we support other boards of the `esp32h2` chip, it would use the `common` folder at the same level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
