tmedicci commented on code in PR #11620: URL: https://github.com/apache/nuttx/pull/11620#discussion_r1469730671
########## arch/risc-v/src/common/espressif/Bootloader.mk: ########## @@ -1,5 +1,5 @@ ############################################################################ -# arch/risc-v/src/espressif/Bootloader.mk +# arch/risc-v/src/common/espressif/Bootloader.mk Review Comment: > but armv7-a is at the same level of common, not put into common/armv7-a, so it's strange that riscv/common contain espressif. Yes, that is the point I highlighted: `armv7-a` refers to the core of an arch that is being included by other chips. `espressif` does not... The level `arch/<arch>/src/<chip>` contains mainly chips or, at least, core definitions of these chips. We kept `esp32c3`, `esp32c6` and `esp32h2` in this level because it refers to a chip. However, they share common sources and headers and, in order to avoid confusion, it seemed that the best place for each would be `nuttx/arch/risc-v/src/common/espressif` (just like `nuttx/arch/risc-v/src/common` contains common source code for all RISC-V, `nuttx/arch/risc-v/src/common/espressif` contains common source code for all Espressif's RISC-V chips). Does it make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
