xiaoxiang781216 commented on a change in pull request #1024:
URL: https://github.com/apache/incubator-nuttx/pull/1024#discussion_r422792147



##########
File path: tools/refresh.sh
##########
@@ -259,7 +229,7 @@ for CONFIG in ${CONFIGS}; do
 
   # Show differences
 
-  if ! $CMPCONFIG $DEFCONFIG defconfig; then
+  if ! diff $DEFCONFIG defconfig; then

Review comment:
       ```
   
====================================================================================
   Configuration/Tool: arty_a7/nsh,CONFIG_RV32IM_TOOLCHAIN_GNU_RVGL
   
------------------------------------------------------------------------------------
     Cleaning...
     Configuring...
     Copy files
     Select CONFIG_HOST_LINUX=y
     Refreshing...
     Disabling CONFIG_RV32IM_TOOLCHAIN_GNU_RVGL
     Enabling CONFIG_RV32IM_TOOLCHAIN_GNU_RVGL
     Building NuttX...
     Normalize arty_a7/nsh
   Saving the new configuration file
   ```
   But the build log will show up "Saving the new configuration file" for each 
config even there isn't any difference at all. @patacongo do you like this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to