patacongo commented on a change in pull request #1024:
URL: https://github.com/apache/incubator-nuttx/pull/1024#discussion_r422783386
##########
File path: tools/refresh.sh
##########
@@ -259,7 +229,7 @@ for CONFIG in ${CONFIGS}; do
# Show differences
- if ! $CMPCONFIG $DEFCONFIG defconfig; then
+ if ! diff $DEFCONFIG defconfig; then
Review comment:
diff should be available. The native build uses the GNUWin32 which are
an ancient port of GNU tools that run natively on Wondows.
Why not just unconditionally give the user the opportunity to save the
defconfig if they provide the --prompt option even if there is not difference.
I like the behavior of a change like:
- if ! $CMPCONFIG $DEFCONFIG defconfig; then
+ $CMPCONFIG $DEFCONFIG defconfig
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
