luchunliang commented on code in PR #10734:
URL: https://github.com/apache/inlong/pull/10734#discussion_r1702442995
##########
inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/elasticsearch/EsIdConfig.java:
##########
@@ -86,6 +88,7 @@ public static EsIdConfig create(DataFlowConfig
dataFlowConfig) {
.separator(sinkConfig.getSeparator())
.indexNamePattern(sinkConfig.getIndexNamePattern())
.fieldList(fields)
+ .charset(Charset.forName(sinkConfig.getEncodingType()))
Review Comment:
It maybe throw Exception for Charset.forName.
It is better to use default charset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
