luchunliang commented on code in PR #10734: URL: https://github.com/apache/inlong/pull/10734#discussion_r1696155227
########## inlong-sdk/transform-sdk/src/main/java/org/apache/inlong/sdk/transform/encode/EsMapSinkEncoder.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sdk.transform.encode; + +import org.apache.inlong.sdk.transform.pojo.EsMapSinkInfo; +import org.apache.inlong.sdk.transform.pojo.FieldInfo; +import org.apache.inlong.sdk.transform.process.Context; +import org.apache.inlong.sdk.transform.process.converter.TypeConverter; + +import lombok.extern.slf4j.Slf4j; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +@Slf4j +public class EsMapSinkEncoder implements SinkEncoder<Map<String, Object>> { + + private final EsMapSinkInfo sinkInfo; + private final Map<String, TypeConverter> converters; + + public EsMapSinkEncoder(EsMapSinkInfo sinkInfo) { + this.sinkInfo = sinkInfo; + this.converters = sinkInfo.getFields() + .stream() + .collect(Collectors.toMap(FieldInfo::getName, FieldInfo::getConverter)); Review Comment: Need to add a filter, if the converter is null. ########## inlong-sdk/transform-sdk/src/main/java/org/apache/inlong/sdk/transform/encode/EsMapSinkEncoder.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sdk.transform.encode; + +import org.apache.inlong.sdk.transform.pojo.EsMapSinkInfo; +import org.apache.inlong.sdk.transform.pojo.FieldInfo; +import org.apache.inlong.sdk.transform.process.Context; +import org.apache.inlong.sdk.transform.process.converter.TypeConverter; + +import lombok.extern.slf4j.Slf4j; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +@Slf4j +public class EsMapSinkEncoder implements SinkEncoder<Map<String, Object>> { + + private final EsMapSinkInfo sinkInfo; + private final Map<String, TypeConverter> converters; + + public EsMapSinkEncoder(EsMapSinkInfo sinkInfo) { + this.sinkInfo = sinkInfo; + this.converters = sinkInfo.getFields() + .stream() + .collect(Collectors.toMap(FieldInfo::getName, FieldInfo::getConverter)); + } + + @Override + public Map<String, Object> encode(SinkData sinkData, Context context) { + Map<String, Object> esMap = new HashMap<>(); + for (FieldInfo fieldInfo : sinkInfo.getFields()) { + String fieldName = fieldInfo.getName(); + String strValue = sinkData.getField(fieldName); + TypeConverter converter = converters.get(fieldName); + try { Review Comment: It is better to add a notnull check. if (converter == null) { continue; } -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
