aloyszhang commented on code in PR #10744: URL: https://github.com/apache/inlong/pull/10744#discussion_r1701677715
########## inlong-sdk/transform-sdk/src/main/java/org/apache/inlong/sdk/transform/process/function/DateFormatFunction.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sdk.transform.process.function; + +import org.apache.inlong.sdk.transform.decode.SourceData; +import org.apache.inlong.sdk.transform.process.Context; +import org.apache.inlong.sdk.transform.process.operator.OperatorTools; +import org.apache.inlong.sdk.transform.process.parser.ValueParser; + +import net.sf.jsqlparser.expression.Expression; +import net.sf.jsqlparser.expression.Function; + +import java.math.BigDecimal; +import java.text.SimpleDateFormat; +import java.util.Date; +import java.util.List; + +/** + * DateFormatFunction + * description: date_format(timestamp,format)--converts timestamp(in seconds) to a value of string in the format + * specified by the date format string. The format string is compatible with Java’s SimpleDateFormat + */ +public class DateFormatFunction implements ValueParser { + + private ValueParser timestampParser; + private ValueParser formatParser; + + /** + * Constructor + * + * @param expr + */ + public DateFormatFunction(Function expr) { + List<Expression> expressions = expr.getParameters().getExpressions(); + timestampParser = OperatorTools.buildParser(expressions.get(0)); + formatParser = OperatorTools.buildParser(expressions.get(1)); + } + + /** + * parse + * + * @param sourceData + * @param rowIndex + * @return + */ + @Override + public Object parse(SourceData sourceData, int rowIndex, Context context) { + Object timestampObj = timestampParser.parse(sourceData, rowIndex, context); + Object formatObj = formatParser.parse(sourceData, rowIndex, context); + BigDecimal timestamp = OperatorTools.parseBigDecimal(timestampObj); + String format = OperatorTools.parseString(formatObj); + SimpleDateFormat sdf = new SimpleDateFormat(format); + // the timestamp is in seconds, multiply 1000 to get milliseconds + Date date = new Date(timestamp.longValue() * 1000); + return sdf.format(date); Review Comment: Please optimize the logic like the `ToDateFunction` does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
