aloyszhang commented on code in PR #10744: URL: https://github.com/apache/inlong/pull/10744#discussion_r1701549942
########## inlong-sdk/transform-sdk/src/main/java/org/apache/inlong/sdk/transform/process/function/ToDateFunction.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sdk.transform.process.function; + +import org.apache.inlong.sdk.transform.decode.SourceData; +import org.apache.inlong.sdk.transform.process.Context; +import org.apache.inlong.sdk.transform.process.operator.OperatorTools; +import org.apache.inlong.sdk.transform.process.parser.ValueParser; + +import net.sf.jsqlparser.expression.Expression; +import net.sf.jsqlparser.expression.Function; + +import java.time.LocalDate; +import java.time.format.DateTimeFormatter; +import java.util.List; + +/** + * ToDateFunction + * description: to_date(string1[, string2])--converts a date string string1 with format string2 (by default ‘yyyy-MM-dd’) to a date + */ +public class ToDateFunction implements ValueParser { + + private ValueParser stringParser1; + private ValueParser stringParser2; + + /** + * Constructor + * + * @param expr + */ + public ToDateFunction(Function expr) { + List<Expression> expressions = expr.getParameters().getExpressions(); + // Determine the number of arguments and build parser + stringParser1 = OperatorTools.buildParser(expressions.get(0)); + if (expressions.size() == 2) { + stringParser2 = OperatorTools.buildParser(expressions.get(1)); + } + } + + /** + * parse + * + * @param sourceData + * @param rowIndex + * @return + */ + @Override + public Object parse(SourceData sourceData, int rowIndex, Context context) { + Object stringObj1 = stringParser1.parse(sourceData, rowIndex, context); + String str1 = OperatorTools.parseString(stringObj1); + String str2 = "yyyy-MM-dd"; + if (stringParser2 != null) { + Object stringObj2 = stringParser2.parse(sourceData, rowIndex, context); + str2 = OperatorTools.parseString(stringObj2); + } + DateTimeFormatter inputFormatter = DateTimeFormatter.ofPattern(str2); + LocalDate date = LocalDate.parse(str1, inputFormatter); + DateTimeFormatter outputFormatter = DateTimeFormatter.ofPattern("yyyy-MM-dd"); Review Comment: DateTimeFormatter should not initialized every time. DateTimeFormatter is thread-safe, so for every single format, one DateTimeFormatter object is enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
