yunqingmoswu commented on code in PR #7905:
URL: https://github.com/apache/inlong/pull/7905#discussion_r1181440436
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -187,7 +190,21 @@ public final class Constants {
.noDefaultValue()
.withDescription(
"The format of multiple sink, it represents the
real format of the raw binary data");
-
+ public static final ConfigOption<String> PATTERN_PARTITION_MAP =
+ ConfigOptions.key("pattern.partition.map")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ "Pattern rules and partition map string, " +
Review Comment:
There are already many places using similar formats such as
'key1=value1&key2=value2...', such as dirty data archives and indicators. It is
recommended to unify this format.
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -187,7 +190,21 @@ public final class Constants {
.noDefaultValue()
.withDescription(
"The format of multiple sink, it represents the
real format of the raw binary data");
-
+ public static final ConfigOption<String> PATTERN_PARTITION_MAP =
+ ConfigOptions.key("pattern.partition.map")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ "Pattern rules and partition map string, " +
+ "eg:
databasePattern1&tablePattern1:partition1,"
+ +
"databasePattern2&tablePattern2:partition2,"
+ + "DEFAULT_PARTITION:partition3");
+ public static final ConfigOption<Map<String, String>>
DATASOURCE_PARTITION_MAP =
Review Comment:
It is recommended not to use the format of map because it is more
troublesome to configure and not easy to understand, you can use the existing
format such as 'key1=value1&key2=value2...'
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -187,7 +190,21 @@ public final class Constants {
.noDefaultValue()
.withDescription(
"The format of multiple sink, it represents the
real format of the raw binary data");
-
+ public static final ConfigOption<String> PATTERN_PARTITION_MAP =
Review Comment:
Maybe 'sink.multiple.partition-pattern' can be reused here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
