[GitHub] [inlong] lordcheng10 commented on a diff in pull request #7905: [INLONG-7903][Sort] Kafka sink supports fixed partition strategy

[via GitHub]

lordcheng10 commented on code in PR #7905:
URL: https://github.com/apache/inlong/pull/7905#discussion_r1179991387


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -187,7 +190,18 @@ public final class Constants {
                     .noDefaultValue()
                     .withDescription(
                             "The format of multiple sink, it represents the 
real format of the raw binary data");
-
+    public static final ConfigOption<String> PATTERN_PARTITION_MAP =
+            ConfigOptions.key("pattern.partition.map")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDescription(
+                            "Pattern rules and partition maps");

Review Comment:
   Fixed.



##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -187,7 +190,18 @@ public final class Constants {
                     .noDefaultValue()
                     .withDescription(
                             "The format of multiple sink, it represents the 
real format of the raw binary data");
-
+    public static final ConfigOption<String> PATTERN_PARTITION_MAP =
+            ConfigOptions.key("pattern.partition.map")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDescription(
+                            "Pattern rules and partition maps");
+    public static final ConfigOption<Map<String, String>> 
DATASOURCE_PARTITION_MAP =
+            ConfigOptions.key("datasource.partition.map")
+                    .mapType()
+                    .noDefaultValue()
+                    .withDescription(
+                            "Datasource and partition maps");

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org