[GitHub] [inlong] gong commented on a diff in pull request #6793: [INLONG-6792][Sort] Supports dirty data side-output for hbase sink

[GitBox]

gong commented on code in PR #6793:
URL: https://github.com/apache/inlong/pull/6793#discussion_r1044044610


##########
inlong-sort/sort-connectors/hbase/src/main/java/org/apache/inlong/sort/hbase/sink/HBaseSinkFunction.java:
##########
@@ -258,10 +296,6 @@ private void reportMetricAfterFlush() {
             }
             resetStateAfterFlush();
         } catch (Exception e) {
-            if (sinkMetricData != null) {
-                sinkMetricData.invokeDirty(rowSize, dataSize);
-            }
-            resetStateAfterFlush();

Review Comment:
   if remove it, metric data would not be consistent when flush fail



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org