[GitHub] [inlong] EMsnap commented on a diff in pull request #6793: [INLONG-6792][Sort] Supports dirty data side-output for hbase sink

[GitBox]

EMsnap commented on code in PR #6793:
URL: https://github.com/apache/inlong/pull/6793#discussion_r1043031591


##########
inlong-sort/sort-connectors/hbase/src/main/java/org/apache/inlong/sort/hbase/sink/HBaseSinkFunction.java:
##########
@@ -133,11 +144,13 @@ public HBaseSinkFunction(
         this.bufferFlushIntervalMillis = bufferFlushIntervalMillis;
         this.inlongMetric = inlongMetric;
         this.inlongAudit = inlongAudit;
+        this.dirtyOptions = dirtyOptions;
+        this.dirtySink = dirtySink;
     }
 
     @Override
     public void open(Configuration parameters) throws Exception {
-        LOG.info("start open ...");
+        LOGGER.info("start open ...");

Review Comment:
   the info log should be more specific 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org