[GitHub] [inlong] e-mhui commented on a diff in pull request #6580: [INLONG-6578][Sort] Fix the write failure after the Doris sets 'sink.properties.columns' option

[GitBox]

e-mhui commented on code in PR #6580:
URL: https://github.com/apache/inlong/pull/6580#discussion_r1027555213


##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicTableSink.java:
##########
@@ -125,5 +143,14 @@ public DynamicTableSink copy() {
     public String asSummaryString() {
         return "Doris Table Sink Of InLong";
     }
+
+    private boolean enableBatchDelete() {
+        try {
+            Schema schema = RestService.getSchema(options, readOptions, LOG);
+            return executionOptions.getEnableDelete() || 
UNIQUE_KEYS_TYPE.equals(schema.getKeysType());
+        } catch (DorisException e) {
+            throw new RuntimeException("Failed fetch doris table schema: " + 
options.getTableIdentifier());
+        }

Review Comment:
   done.



##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicTableSink.java:
##########
@@ -47,6 +55,9 @@ public class DorisDynamicTableSink implements 
DynamicTableSink {
     private final String inlongMetric;
     private final String auditHostAndPorts;
     private final Integer parallelism;
+    private static final String UNIQUE_KEYS_TYPE = "UNIQUE_KEYS";
+    public static final String COLUMNS_KEY = "columns";
+    public static final String DORIS_DELETE_SIGN = "__DORIS_DELETE_SIGN__";

Review Comment:
   done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org