[GitHub] [inlong] healchow commented on a diff in pull request #6580: [INLONG-6578][Sort] Fix the write failure after the Doris sets 'sink.properties.columns' option

Sun, 20 Nov 2022 18:50:29 -0800 


healchow commented on code in PR #6580:
URL: https://github.com/apache/inlong/pull/6580#discussion_r1027499535


##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicTableSink.java:
##########
@@ -47,6 +55,9 @@ public class DorisDynamicTableSink implements 
DynamicTableSink {
     private final String inlongMetric;
     private final String auditHostAndPorts;
     private final Integer parallelism;
+    private static final String UNIQUE_KEYS_TYPE = "UNIQUE_KEYS";
+    public static final String COLUMNS_KEY = "columns";
+    public static final String DORIS_DELETE_SIGN = "__DORIS_DELETE_SIGN__";

Review Comment:
   Do these two constants need to be set to `public`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to