yunqingmoswu commented on code in PR #6123: URL: https://github.com/apache/inlong/pull/6123#discussion_r991866312
########## inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/table/KafkaDynamicTableFactory.java: ########## @@ -325,7 +374,9 @@ public DynamicTableSink createDynamicTableSink(Context context) { getSinkSemantic(tableOptions), parallelism, inlongMetric, - auditHostAndPorts); + auditHostAndPorts, + innerValueDecodingFormat, + tableOptions.getOptional(TOPIC_PATTERN).orElse(null)); Review Comment: Yes i reused the 'TOPIC_PATTERN' for kafka sink, maybe you can define some common names for other multiple sink connector, such as 'database-pattern', 'table-pattern', and so on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org