thesumery commented on code in PR #6123:
URL: https://github.com/apache/inlong/pull/6123#discussion_r991850958
##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/KafkaDynamicSink.java:
##########
@@ -82,7 +81,8 @@ public class KafkaDynamicSink implements DynamicTableSink,
SupportsWritingMetada
/**
* Optional format for encoding keys to Kafka.
*/
- protected final @Nullable EncodingFormat<SerializationSchema<RowData>>
keyEncodingFormat;
+ protected final @Nullable
+ EncodingFormat<SerializationSchema<RowData>> keyEncodingFormat;
Review Comment:
format problem?
##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/KafkaDynamicSink.java:
##########
@@ -98,19 +98,22 @@ public class KafkaDynamicSink implements DynamicTableSink,
SupportsWritingMetada
/**
* Prefix that needs to be removed from fields when constructing the
physical data type.
*/
- protected final @Nullable String keyPrefix;
+ protected final @Nullable
Review Comment:
format problem?
##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/KafkaDynamicSink.java:
##########
@@ -98,19 +98,22 @@ public class KafkaDynamicSink implements DynamicTableSink,
SupportsWritingMetada
/**
* Prefix that needs to be removed from fields when constructing the
physical data type.
*/
- protected final @Nullable String keyPrefix;
+ protected final @Nullable
+ String keyPrefix;
/**
* The Kafka topic to write to.
*/
protected final String topic;
+ protected final String topicPattern;
/**
* Properties for the Kafka producer.
*/
protected final Properties properties;
/**
* Partitioner to select Kafka partition for each item.
*/
- protected final @Nullable FlinkKafkaPartitioner<RowData> partitioner;
+ protected final @Nullable
Review Comment:
format problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
