[GitHub] [inlong] gong commented on a diff in pull request #5906: [INLONG-5903][Sort] Make InLong metric constructs factory more cohesive

[GitBox]

gong commented on code in PR #5906:
URL: https://github.com/apache/inlong/pull/5906#discussion_r973904019


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/SourceMetricData.java:
##########
@@ -247,19 +229,4 @@ public void outputMetrics(long rowCountSize, long 
rowDataSize) {
                     rowDataSize);
         }
     }
-
-    @Override
-    public String toString() {
-        return "SourceMetricData{"
-                + "groupId='" + groupId + '\''
-                + ", streamId='" + streamId + '\''
-                + ", nodeId='" + nodeId + '\''
-                + ", numRecordsIn=" + numRecordsIn.getCount()
-                + ", numBytesIn=" + numBytesIn.getCount()
-                + ", numRecordsInForMeter=" + numRecordsInForMeter.getCount()
-                + ", numBytesInForMeter=" + numBytesInForMeter.getCount()
-                + ", numRecordsInPerSecond=" + numRecordsInPerSecond.getRate()
-                + ", numBytesInPerSecond=" + numBytesInPerSecond.getRate()
-                + '}';
-    }

Review Comment:
   Add toString() for printing some data when invoke snapshotState. Because it 
is convenient to troubleshooting metrics problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org