[GitHub] [inlong] gong commented on a diff in pull request #5906: [INLONG-5903][Sort] Make InLong metric constructs factory more cohesive

[GitBox]

gong commented on code in PR #5906:
URL: https://github.com/apache/inlong/pull/5906#discussion_r973900026


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/SourceMetricData.java:
##########
@@ -58,31 +57,24 @@ public class SourceMetricData implements MetricData {
     private AuditImp auditImp;
 
     public SourceMetricData(MetricOption option, MetricGroup metricGroup) {
-        this(option.getGroupId(), option.getStreamId(), option.getNodeId(),
-                option.getRegisteredMetric(), metricGroup, 
option.getIpPorts());
+        this(option.getLabels(), option.getRegisteredMetric(), metricGroup, 
option.getIpPorts());
     }
 
     public SourceMetricData(
-            String groupId,
-            String streamId,
-            String nodeId,
+            Map<String, String> labels,
             @Nullable RegisteredMetric registeredMetric,
             MetricGroup metricGroup,
             @Nullable String auditHostAndPorts) {
         this.metricGroup = metricGroup;
-        if (groupId != null && streamId != null && nodeId != null) {
-            this.groupId = groupId;
-            this.streamId = streamId;
-            this.nodeId = nodeId;
-            switch (registeredMetric) {
-                default:
-                    registerMetricsForNumRecordsIn();
-                    registerMetricsForNumBytesIn();
-                    registerMetricsForNumBytesInPerSecond();
-                    registerMetricsForNumRecordsInPerSecond();
-                    break;
-
-            }
+        this.labels = labels;
+        switch (registeredMetric) {
+            default:
+                registerMetricsForNumRecordsIn();
+                registerMetricsForNumBytesIn();
+                registerMetricsForNumBytesInPerSecond();
+                registerMetricsForNumRecordsInPerSecond();
+                break;

Review Comment:
   lost numRecordsInForMeter and numBytesInForMeter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org