healchow commented on code in PR #5381: URL: https://github.com/apache/inlong/pull/5381#discussion_r945223518
########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/AbstractDataNodeOperator.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.service.node; + +import org.apache.inlong.manager.common.consts.InlongConstants; +import org.apache.inlong.manager.common.enums.ErrorCodeEnum; +import org.apache.inlong.manager.common.exceptions.BusinessException; +import org.apache.inlong.manager.common.util.CommonBeanUtils; +import org.apache.inlong.manager.dao.entity.DataNodeEntity; +import org.apache.inlong.manager.dao.mapper.DataNodeEntityMapper; +import org.apache.inlong.manager.pojo.node.DataNodeRequest; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.transaction.annotation.Isolation; +import org.springframework.transaction.annotation.Transactional; + +public abstract class AbstractDataNodeOperator implements DataNodeOperator { Review Comment: Please add Java docs for new classes. ########## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/hive/HiveDataNodeDTO.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.pojo.node.hive; + +import com.fasterxml.jackson.databind.DeserializationFeature; +import com.fasterxml.jackson.databind.ObjectMapper; +import io.swagger.annotations.ApiModel; +import io.swagger.annotations.ApiModelProperty; +import lombok.AllArgsConstructor; +import lombok.Builder; +import lombok.Data; +import lombok.NoArgsConstructor; +import org.apache.commons.lang3.StringUtils; +import org.apache.inlong.manager.common.enums.ErrorCodeEnum; +import org.apache.inlong.manager.common.exceptions.BusinessException; +import org.apache.inlong.manager.common.util.AESUtils; + +import javax.validation.constraints.NotNull; +import java.nio.charset.StandardCharsets; + +/** + * hive data node info + */ +@Data +@Builder +@NoArgsConstructor +@AllArgsConstructor +@ApiModel("Hive data node info") +public class HiveDataNodeDTO { + + private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper(); // thread safe + + @ApiModelProperty("Hive JDBC URL, such as jdbc:hive2://${ip}:${port}") + private String jdbcUrl; + + @ApiModelProperty("Username of the Hive server") + private String username; + + @ApiModelProperty("User password of the Hive server") + private String password; + + @ApiModelProperty("Version for Hive, such as: 3.2.1") + private String hiveVersion; + + @ApiModelProperty("Config directory of Hive on HDFS, needed by sort in light mode, must include hive-site.xml") + private String hiveConfDir; + + @ApiModelProperty("Password encrypt version") + private Integer encryptVersion; + + /** + * Get the dto instance from the request + */ + public static HiveDataNodeDTO getFromRequest(HiveDataNodeRequest request) throws Exception { + + Integer encryptVersion = AESUtils.getCurrentVersion(null); + String passwd = null; + if (StringUtils.isNotEmpty(request.getToken())) { + passwd = AESUtils.encryptToString(request.getToken().getBytes(StandardCharsets.UTF_8), + encryptVersion); + } + return HiveDataNodeDTO.builder() + .jdbcUrl(request.getJdbcUrl()) + .username(request.getUsername()) + .password(passwd) + .hiveVersion(request.getHiveVersion()) + .hiveConfDir(request.getHiveConfDir()) + .encryptVersion(encryptVersion) + .build(); + } + + /** + * Get the dto instance from the JSON string. + */ + public static HiveDataNodeDTO getFromJson(@NotNull String extParams) { + try { + OBJECT_MAPPER.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); + return OBJECT_MAPPER.readValue(extParams, HiveDataNodeDTO.class).decryptPassword(); + } catch (Exception e) { + throw new BusinessException(ErrorCodeEnum.GROUP_INFO_INCORRECT.getMessage()); Review Comment: Suggest adding an error log here. ########## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/DataNodeInfo.java: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.pojo.node; + +import com.fasterxml.jackson.annotation.JsonFormat; +import com.fasterxml.jackson.annotation.JsonTypeInfo; +import io.swagger.annotations.ApiModel; +import io.swagger.annotations.ApiModelProperty; +import lombok.AllArgsConstructor; +import lombok.Data; +import lombok.NoArgsConstructor; + +import java.util.Date; + +/** + * Data node info + */ +@Data +@NoArgsConstructor +@AllArgsConstructor +@ApiModel("Data node info") +@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, visible = true, property = "type") +public abstract class DataNodeInfo { + + @ApiModelProperty(value = "Primary key") + private Integer id; + + @ApiModelProperty(value = "Cluster name") + private String name; + + @ApiModelProperty(value = "Cluster type, including TUBEMQ, PULSAR, DATAPROXY, etc.") + private String type; + + @ApiModelProperty(value = "Cluster url") + private String url; + + @ApiModelProperty(value = "Cluster tags, separated by commas") + private String clusterTags; + + @ApiModelProperty(value = "Extension tag") + private String extTag; + + @ApiModelProperty(value = "Cluster token") Review Comment: Why `Cluster token`? ########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/hive/HiveDataNodeOperator.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.service.node.hive; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.commons.lang3.StringUtils; +import org.apache.inlong.manager.common.consts.DataNodeType; +import org.apache.inlong.manager.common.enums.ErrorCodeEnum; +import org.apache.inlong.manager.common.exceptions.BusinessException; +import org.apache.inlong.manager.common.util.CommonBeanUtils; +import org.apache.inlong.manager.dao.entity.DataNodeEntity; +import org.apache.inlong.manager.pojo.node.DataNodeInfo; +import org.apache.inlong.manager.pojo.node.DataNodeRequest; +import org.apache.inlong.manager.pojo.node.hive.HiveDataNodeDTO; +import org.apache.inlong.manager.pojo.node.hive.HiveDataNodeInfo; +import org.apache.inlong.manager.pojo.node.hive.HiveDataNodeRequest; +import org.apache.inlong.manager.service.node.AbstractDataNodeOperator; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.stereotype.Service; + +@Service +public class HiveDataNodeOperator extends AbstractDataNodeOperator { + + private static final Logger LOGGER = LoggerFactory.getLogger(HiveDataNodeOperator.class); + + @Autowired + private ObjectMapper objectMapper; + + @Override + public Boolean accept(String dataNodeType) { + return getDataNodeType().equals(dataNodeType); + } + + @Override + public String getDataNodeType() { + return DataNodeType.HIVE; + } + + @Override + public DataNodeInfo getFromEntity(DataNodeEntity entity) { + if (entity == null) { + throw new BusinessException(ErrorCodeEnum.DATA_NODE_NOT_FOUND); + } + + HiveDataNodeInfo hiveDataNodeInfo = new HiveDataNodeInfo(); + CommonBeanUtils.copyProperties(entity, hiveDataNodeInfo); + if (StringUtils.isNotBlank(entity.getExtParams())) { + HiveDataNodeDTO dto = HiveDataNodeDTO.getFromJson(entity.getExtParams()); + CommonBeanUtils.copyProperties(dto, hiveDataNodeInfo); + } + + LOGGER.info("success to get data node info from entity"); + return hiveDataNodeInfo; + } + + @Override + protected void setTargetEntity(DataNodeRequest request, DataNodeEntity targetEntity) { + HiveDataNodeRequest hiveDataNodeRequest = (HiveDataNodeRequest) request; + CommonBeanUtils.copyProperties(hiveDataNodeRequest, targetEntity, true); + try { + HiveDataNodeDTO dto = HiveDataNodeDTO.getFromRequest(hiveDataNodeRequest); + targetEntity.setExtParams(objectMapper.writeValueAsString(dto)); + LOGGER.info("success to set entity for hive data node"); + } catch (Exception e) { + throw new BusinessException(ErrorCodeEnum.SOURCE_INFO_INCORRECT.getMessage()); Review Comment: Add an error log for this exception. ########## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/hive/HiveDataNodeInfo.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.pojo.node.hive; + +import io.swagger.annotations.ApiModel; +import io.swagger.annotations.ApiModelProperty; +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.ToString; +import org.apache.inlong.manager.common.consts.DataNodeType; +import org.apache.inlong.manager.common.util.CommonBeanUtils; +import org.apache.inlong.manager.common.util.JsonTypeDefine; +import org.apache.inlong.manager.pojo.node.DataNodeInfo; + +/** + * Data node info for hive + */ +@Data +@ToString(callSuper = true) +@EqualsAndHashCode(callSuper = true) +@JsonTypeDefine(value = DataNodeType.HIVE) +@ApiModel("Data node info for hive") +public class HiveDataNodeInfo extends DataNodeInfo { + + @ApiModelProperty("Hive JDBC URL, such as jdbc:hive2://${ip}:${port}") + private String jdbcUrl; + + @ApiModelProperty("Username of the Hive server") + private String username; Review Comment: Suggest extracting the `username` and `password` into the parent class. By the way, the `token` field can replace the `password` field. ########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/hive/HiveDataNodeOperator.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.service.node.hive; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.commons.lang3.StringUtils; +import org.apache.inlong.manager.common.consts.DataNodeType; +import org.apache.inlong.manager.common.enums.ErrorCodeEnum; +import org.apache.inlong.manager.common.exceptions.BusinessException; +import org.apache.inlong.manager.common.util.CommonBeanUtils; +import org.apache.inlong.manager.dao.entity.DataNodeEntity; +import org.apache.inlong.manager.pojo.node.DataNodeInfo; +import org.apache.inlong.manager.pojo.node.DataNodeRequest; +import org.apache.inlong.manager.pojo.node.hive.HiveDataNodeDTO; +import org.apache.inlong.manager.pojo.node.hive.HiveDataNodeInfo; +import org.apache.inlong.manager.pojo.node.hive.HiveDataNodeRequest; +import org.apache.inlong.manager.service.node.AbstractDataNodeOperator; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.stereotype.Service; + +@Service +public class HiveDataNodeOperator extends AbstractDataNodeOperator { + + private static final Logger LOGGER = LoggerFactory.getLogger(HiveDataNodeOperator.class); + + @Autowired + private ObjectMapper objectMapper; + + @Override + public Boolean accept(String dataNodeType) { + return getDataNodeType().equals(dataNodeType); + } + + @Override + public String getDataNodeType() { + return DataNodeType.HIVE; + } + + @Override + public DataNodeInfo getFromEntity(DataNodeEntity entity) { + if (entity == null) { + throw new BusinessException(ErrorCodeEnum.DATA_NODE_NOT_FOUND); + } + + HiveDataNodeInfo hiveDataNodeInfo = new HiveDataNodeInfo(); + CommonBeanUtils.copyProperties(entity, hiveDataNodeInfo); + if (StringUtils.isNotBlank(entity.getExtParams())) { + HiveDataNodeDTO dto = HiveDataNodeDTO.getFromJson(entity.getExtParams()); + CommonBeanUtils.copyProperties(dto, hiveDataNodeInfo); + } + + LOGGER.info("success to get data node info from entity"); Review Comment: Change the log level to debug. ########## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/DataNodeInfo.java: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.pojo.node; + +import com.fasterxml.jackson.annotation.JsonFormat; +import com.fasterxml.jackson.annotation.JsonTypeInfo; +import io.swagger.annotations.ApiModel; +import io.swagger.annotations.ApiModelProperty; +import lombok.AllArgsConstructor; +import lombok.Data; +import lombok.NoArgsConstructor; + +import java.util.Date; + +/** + * Data node info + */ +@Data +@NoArgsConstructor +@AllArgsConstructor +@ApiModel("Data node info") +@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, visible = true, property = "type") +public abstract class DataNodeInfo { + + @ApiModelProperty(value = "Primary key") + private Integer id; + + @ApiModelProperty(value = "Cluster name") + private String name; + + @ApiModelProperty(value = "Cluster type, including TUBEMQ, PULSAR, DATAPROXY, etc.") + private String type; + + @ApiModelProperty(value = "Cluster url") + private String url; + + @ApiModelProperty(value = "Cluster tags, separated by commas") + private String clusterTags; + + @ApiModelProperty(value = "Extension tag") + private String extTag; + + @ApiModelProperty(value = "Cluster token") + private String token; Review Comment: Why no `username` for this token? ########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/DataNodeOperator.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.service.node; + +import org.apache.inlong.manager.dao.entity.DataNodeEntity; +import org.apache.inlong.manager.pojo.node.DataNodeInfo; +import org.apache.inlong.manager.pojo.node.DataNodeRequest; + +public interface DataNodeOperator { Review Comment: Add Java doc, please. ########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/hive/HiveDataNodeOperator.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.service.node.hive; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.commons.lang3.StringUtils; +import org.apache.inlong.manager.common.consts.DataNodeType; +import org.apache.inlong.manager.common.enums.ErrorCodeEnum; +import org.apache.inlong.manager.common.exceptions.BusinessException; +import org.apache.inlong.manager.common.util.CommonBeanUtils; +import org.apache.inlong.manager.dao.entity.DataNodeEntity; +import org.apache.inlong.manager.pojo.node.DataNodeInfo; +import org.apache.inlong.manager.pojo.node.DataNodeRequest; +import org.apache.inlong.manager.pojo.node.hive.HiveDataNodeDTO; +import org.apache.inlong.manager.pojo.node.hive.HiveDataNodeInfo; +import org.apache.inlong.manager.pojo.node.hive.HiveDataNodeRequest; +import org.apache.inlong.manager.service.node.AbstractDataNodeOperator; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.stereotype.Service; + +@Service +public class HiveDataNodeOperator extends AbstractDataNodeOperator { + + private static final Logger LOGGER = LoggerFactory.getLogger(HiveDataNodeOperator.class); + + @Autowired + private ObjectMapper objectMapper; + + @Override + public Boolean accept(String dataNodeType) { + return getDataNodeType().equals(dataNodeType); + } + + @Override + public String getDataNodeType() { + return DataNodeType.HIVE; + } + + @Override + public DataNodeInfo getFromEntity(DataNodeEntity entity) { + if (entity == null) { + throw new BusinessException(ErrorCodeEnum.DATA_NODE_NOT_FOUND); + } + + HiveDataNodeInfo hiveDataNodeInfo = new HiveDataNodeInfo(); + CommonBeanUtils.copyProperties(entity, hiveDataNodeInfo); + if (StringUtils.isNotBlank(entity.getExtParams())) { + HiveDataNodeDTO dto = HiveDataNodeDTO.getFromJson(entity.getExtParams()); + CommonBeanUtils.copyProperties(dto, hiveDataNodeInfo); + } + + LOGGER.info("success to get data node info from entity"); + return hiveDataNodeInfo; + } + + @Override + protected void setTargetEntity(DataNodeRequest request, DataNodeEntity targetEntity) { + HiveDataNodeRequest hiveDataNodeRequest = (HiveDataNodeRequest) request; + CommonBeanUtils.copyProperties(hiveDataNodeRequest, targetEntity, true); + try { + HiveDataNodeDTO dto = HiveDataNodeDTO.getFromRequest(hiveDataNodeRequest); + targetEntity.setExtParams(objectMapper.writeValueAsString(dto)); + LOGGER.info("success to set entity for hive data node"); Review Comment: Change the log level to debug. ########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/DataNodeServiceImpl.java: ########## @@ -65,33 +70,38 @@ public Integer save(DataNodeRequest request, String operator) { LOGGER.error(errMsg); throw new BusinessException(errMsg); } - DataNodeEntity entity = CommonBeanUtils.copyProperties(request, DataNodeEntity::new); - entity.setCreator(operator); - entity.setModifier(operator); - dataNodeMapper.insert(entity); - + // According to the data type, save sink information + DataNodeOperator operation = operatorFactory.getInstance(request.getType()); Review Comment: Change the variable to `operator`. ########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java: ########## @@ -266,20 +265,8 @@ public Boolean delete(Integer id, String operator) { StreamSinkEntity entity = sinkMapper.selectByPrimaryKey(id); Preconditions.checkNotNull(entity, ErrorCodeEnum.SINK_INFO_NOT_FOUND.getMessage()); groupCheckService.checkGroupStatus(entity.getInlongGroupId(), operator); - - entity.setPreviousStatus(entity.getStatus()); - entity.setStatus(InlongConstants.DELETED_STATUS); - entity.setIsDeleted(id); - entity.setModifier(operator); - entity.setModifyTime(new Date()); - int rowCount = sinkMapper.updateByPrimaryKeySelective(entity); - if (rowCount != InlongConstants.AFFECTED_ONE_ROW) { - LOGGER.error("sink has already updated with groupId={}, streamId={}, name={}, curVersion={}", - entity.getInlongGroupId(), entity.getInlongStreamId(), entity.getSinkName(), entity.getVersion()); - throw new BusinessException(ErrorCodeEnum.CONFIG_EXPIRED); - } - sinkFieldMapper.logicDeleteAll(id); - + StreamSinkOperator operation = operatorFactory.getInstance(entity.getSinkType()); Review Comment: Suggest changing the variable to `operator`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
