[GitHub] [inlong] healchow commented on a diff in pull request #5381: [INLONG-5380][Manager] Modify the saving function of datanode

[GitBox]

healchow commented on code in PR #5381:
URL: https://github.com/apache/inlong/pull/5381#discussion_r939684896


##########
inlong-manager/manager-service/src/test/java/org/apache/inlong/manager/service/core/impl/DataNodeServiceTest.java:
##########
@@ -96,17 +98,17 @@ public void testDataService() {
         Assertions.assertNotNull(id);
 
         // test get data node
-        DataNodeResponse nodeResponse = dataNodeService.get(id);
-        Assertions.assertNotNull(nodeResponse);
-        Assertions.assertEquals(type, nodeResponse.getType());
+        DataNodeInfo dataNodeInfo = dataNodeService.get(id);
+        Assertions.assertNotNull(dataNodeInfo);
+        Assertions.assertEquals(type, dataNodeInfo.getType());
 
         // test get data node list
-        PageInfo<DataNodeResponse> listDataNode = this.listOpt(type, nodeName);
+        PageInfo<DataNodeInfo> listDataNode = this.listOpt(type, nodeName);
         Assertions.assertEquals(listDataNode.getTotal(), 1);
 
         // test update data node
         String newNodeName = "kafkaNode1";
-        String newType = "KAFKA";
+        String newType = "HIVE";

Review Comment:
   Suggest using a String constant instead of a String variable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org