atharvalade opened a new pull request, #3200:
URL: https://github.com/apache/iggy/pull/3200
## Which issue does this PR close?
Closes #3171
## Rationale
Silent error swallowing in connector SDK made debugging connector failures
nearly impossible — only generic "Failed to poll/consume" messages appeared
with zero root-cause context.
## What changed?
The source SDK's `handle_messages` loop discarded the `Err` variant from
`source.poll()` and `postcard::to_allocvec`, logging only a static string. The
sink SDK had the same pattern across all `postcard::from_bytes` deserialization
calls, `try_into_payload`, and `sink.consume()` (which wasn't logged at all).
All `let Ok(x) = expr else { ... }` patterns are replaced with `match` to
bind and format the underlying error into the existing log lines. No behavioral
change — same control flow (continue/return codes) — just makes the root cause
visible.
## Local Execution
- Passed / passed
- Pre-commit hooks ran / ran (`cargo fmt --check`, `cargo clippy`,
`trailing-whitespace`, `trailing-newline`, `license-headers` all green)
## AI Usage
1. Opus 4.6
2. used to locate the pattern and write the match arms
3. Verified via `cargo clippy`, `cargo fmt --check`, and full CI script
suite locally
4. Yes, all code can be explained
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
