atharvalade opened a new pull request, #3199:
URL: https://github.com/apache/iggy/pull/3199

   ## Which issue does this PR close?
   
   Closes #3172
   
   ## Rationale
   
   Bug fixes or new type support added to one copy of `extract_column_value` 
silently won't apply to the other, causing divergence between sequential and 
parallel code paths.
   
   ## What changed?
   
   The Postgres source connector had `extract_column_value` as a method on 
`PostgresSource` (`&self`), making it impossible to call from static/parallel 
contexts without duplicating the function. Any future parallel/chunked path 
would need its own copy.
   
   Converted it to a single free function callable from any context. Added 
missing `DATE` (via `chrono::NaiveDate`) and `BPCHAR` type handling that the 
parallel copy on the benchmark branch had but this version lacked.
   
   ## Local Execution
   
   - Passed
   - Pre-commit hooks ran
   
   ## AI Usage
   
   1. Opus 4.6
   2. exploration and implementation guidance
   3. Verified via cargo check, clippy -D warnings, fmt --check, all 19 unit 
tests passing, CI lint scripts passing
   4. Yes, all code can be explained


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to