hubcio commented on code in PR #3140:
URL: https://github.com/apache/iggy/pull/3140#discussion_r3130005592
##########
core/connectors/sinks/quickwit_sink/src/lib.rs:
##########
@@ -114,34 +114,65 @@ impl QuickwitSink {
pub async fn ingest(&self, messages: Vec<simd_json::OwnedValue>) ->
Result<(), Error> {
let url = format!(
- "{}/api/v1/{}/ingest?commit=auto",
+ "{}/api/v1/{}/ingest?commit=force",
Review Comment:
two unrelated changes folded into this pr's v2/v3 influxdb scope. (1) url
switched from `?commit=auto` to `?commit=force` - synchronous-commit semantic
change that collapses ingest throughput on a different connector entirely. (2)
at line 138, `body.clone()` runs on every retry attempt up to
`MAX_INGEST_RETRIES + 1 = 6` times - full string copy of the entire ingest
payload. split both into a separate quickwit-only pr; if the retry stays, hold
body as `Bytes` and clone the refcount.
in general, if you are implementing influxdb, then try to not touch other
connectors. if you're changing connectors SDK, do it first for all connectors
in separate PR then create another PR for influxdb connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
