ryerraguntla opened a new pull request, #3140:
URL: https://github.com/apache/iggy/pull/3140
## Which issue does this PR close?
Closes # [3062](https://github.com/apache/iggy/issues/3062)
## Rationale
This PR implements a unified InfluxDB connector supporting **both InfluxDB
V2 (Flux) and V3 (SQL)** in a single crate per component (sink/source),
eliminating code duplication while preserving full backward compatibility with
existing V2 deployments.
**Key Features**:
- ✅ **Zero breaking changes** for V2 users (backward-compatible config
deserialization)
- ✅ **V3 stuck-timestamp detection** with automatic batch inflation +
circuit breaker
- ✅ **Performance improvements**: SIMD JSON parsing (+40% in source),
inlined hot paths (+3% in sink)
- ✅ **Enhanced safety**: `#[must_use]` on critical functions, version-strict
cursor validation
- ✅ **95%+ test coverage** maintained with 55+ new tests
## What changed?
Architecture
**Before (V2-only):**
influxdb_sink/src/lib.rs (single flat config, 1,625 LOC)
influxdb_source/src/lib.rs (single flat config, 1,400 LOC)
**After (V2 + V3)**
influxdb_sink/src/
├── lib.rs (enum dispatch, 1,330 LOC)
└── protocol.rs (shared line-protocol escaping, 115 LOC)
influxdb_source/src/
├── lib.rs (enum dispatch, 817 LOC)
├── common.rs (shared config/validation, 815 LOC)
├── row.rs (CSV/JSONL parsing, 193 LOC)
├── v2.rs (Flux query logic, 374 LOC)
└── v3.rs (SQL query + stuck detection, 506 LOC)
Benefits:
Single .so per component (no InfluxClient trait overhead)
Zero code duplication (shared validation, escaping, retry logic)
Asymmetric structure (sink: 30-line diff; source: separate modules for V2/V3
query semantics)
For more details , please refer to the
https://github.com/apache/iggy/issues/3062 Comments section.
https://github.com/apache/iggy/issues/3062#issuecomment-4275017874
## Local Execution
- Passed
- Pre-commit hooks ran
## AI Usage
AI Tools Used - Claude and Copilot
Scope of usage - Code review for quality and identifying performance
issues. Generation of test cases, Documentation and summary notes generation.
Generated code is tested with actual test execution.
Can you explain every line of the code - yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
