avirajkhare00 commented on issue #3007: URL: https://github.com/apache/iggy/issues/3007#issuecomment-4115338637
Follow-up from reviewing #3019: the hardcoding is concentrated in `.github/workflows/_test.yml`, but it is not all the same kind of hardcoding. A few values are CI-owned and are reasonable to keep inline: pinned tool versions/checksums, kind cluster shape, ingress-nginx install, smoke-test hosts, and ingress class. Those describe the CI environment, not the chart. The part that looks over-hardcoded is where the workflow repeats chart-owned values that already exist under `helm/charts/iggy/`, for example: - `helm/charts/iggy/Chart.yaml`: chart `version` and `appVersion` - `helm/charts/iggy/values.yaml`: `server.image.tag` and `ui.image.tag` defaults That makes `_test.yml` a second source of truth and means ordinary chart/version bumps need matching CI edits. I think the cleaner split is: - keep CI/runtime-specific values inline in `_test.yml` - move chart-specific render fixtures into the `helm/charts/iggy/` tree, or derive them directly from chart files, so the Helm directory stays the owner of chart data Issue #3007 explicitly asked for an inline step plus the 6 render scenarios, so some workflow verbosity is expected. The reusable part is the chart data, not the whole smoke-test setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
