avirajkhare00 commented on issue #3007:
URL: https://github.com/apache/iggy/issues/3007#issuecomment-4114978311

   Implemented in #3019.
   
   Final scope:
   - added the `helm` component in `.github/config/components.yml` so `helm/**` 
changes route into the existing `other_matrix` with `validate`
   - added pinned Helm install, `helm lint --strict`, and the 6 requested `helm 
template` scenarios in `.github/workflows/_test.yml`
   - kept this in the existing CI path; no `_detect.yml` or `pre-merge.yml` 
changes were needed
   
   One adjustment from the original 2-file sketch: to make the legacy 
Kubernetes 1.18 case real, I also updated 
`helm/charts/iggy/templates/ingress.yaml` and 
`helm/charts/iggy/templates/hpa.yaml`. With the previous chart logic, 
`--kube-version 1.18.0` alone did not deterministically render the legacy API 
branches under Helm capabilities, so CI could pass without actually exercising 
`networking.k8s.io/v1beta1` and `autoscaling/v2beta2`. The templates now select 
those APIs from `KubeVersion`, and the workflow asserts that the legacy render 
produced them.
   
   Validation status:
   - local Helm validation passed for the full 6-scenario matrix
   - `Other • helm/validate / run` is passing on the upstream PR as well
   
   I followed the command-in-CI approach discussed here and did not add a 
separate `kind` smoke test in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to