[GitHub] [hudi] nsivabalan commented on a change in pull request #4420: [HUDI-1847] [UNDER_DISCUSSION] Adding async scheduling support for spark datasource path for compaction and clustering

[GitBox]

nsivabalan commented on a change in pull request #4420:
URL: https://github.com/apache/hudi/pull/4420#discussion_r773979454



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -460,24 +460,24 @@ protected void postCommit(HoodieTable<T, I, K, O> table, 
HoodieCommitMetadata me
   }
 
   protected void runTableServicesInline(HoodieTable<T, I, K, O> table, 
HoodieCommitMetadata metadata, Option<Map<String, String>> extraMetadata) {
-    if (config.inlineTableServices()) {
+    if (config.inlineTableServices() || config.scheduleAsyncTableServices()) {
       if (config.isMetadataTableEnabled()) {
         table.getHoodieView().sync();
       }
       // Do an inline compaction if enabled
-      if (config.inlineCompactionEnabled()) {
+      if (config.inlineCompactionEnabled() || 
config.scheduleAsyncCompaction()) {
         runAnyPendingCompactions(table);
         metadata.addMetadata(HoodieCompactionConfig.INLINE_COMPACT.key(), 
"true");

Review comment:
       I had some local changes which I missed to update here. essentially, we 
can schedule only if there are no other pending jobs. Will push my changes 
along with addressing other feedback as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org