[GitHub] [hudi] danny0405 commented on a change in pull request #4420: [HUDI-1847] [UNDER_DISCUSSION] Adding async scheduling support for spark datasource path for compaction and clustering

[GitBox]

danny0405 commented on a change in pull request #4420:
URL: https://github.com/apache/hudi/pull/4420#discussion_r773684448



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -989,12 +989,14 @@ protected void rollbackFailedWrites(Map<String, 
Option<HoodiePendingRollbackInfo
   /**
    * Performs a compaction operation on a table, serially before or after an 
insert/upsert action.
    */
-  protected Option<String> inlineCompact(Option<Map<String, String>> 
extraMetadata) {
+  protected Option<String> inlineCompact(Option<Map<String, String>> 
extraMetadata, boolean executeInline) {
     Option<String> compactionInstantTimeOpt = 
scheduleCompaction(extraMetadata);
-    compactionInstantTimeOpt.ifPresent(compactInstantTime -> {

Review comment:
       The method name is `inlineCompact` and why is still a flag 
`executeInline` there ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org