wombatu-kun commented on code in PR #20042:
URL: https://github.com/apache/hudi/pull/20042#discussion_r4089758409
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -816,7 +815,7 @@ public HoodieTableFileSystemView
getMetadataFileSystemView() {
public Map<String, String> stats() {
MetadataPartitionType[] metadataPartitionTypes =
MetadataPartitionType.getValidValues(metadataMetaClient.getTableConfig().getTableVersion());
Set<String> allMetadataPartitionPaths =
Arrays.stream(metadataPartitionTypes).map(MetadataPartitionType::getPartitionPath).collect(Collectors.toSet());
- return metrics.map(m -> m.getStats(true, metadataMetaClient, this,
allMetadataPartitionPaths)).orElseGet(HashMap::new);
+ return HoodieMetadataMetrics.computeStats(true, metadataMetaClient, this,
allMetadataPartitionPaths);
Review Comment:
`ShowMetadataTableStatsProcedure` also calls `stats()`, and
`TestMetadataProcedure` still asserts that `show_metadata_table_stats` returns
zero rows, which is the `Expected 0, but got 29` failure in both the Azure and
the GitHub spark4.2 Scala CI runs. Please flip that assertion to look for a
positive `partitionCount` row, as the CLI test now does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
