hudi-agent commented on code in PR #20042:
URL: https://github.com/apache/hudi/pull/20042#discussion_r4087474432
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataMetrics.java:
##########
@@ -95,6 +95,10 @@ public HoodieMetadataMetrics(HoodieMetricsConfig
metricsConfig, HoodieStorage st
}
public Map<String, String> getStats(boolean detailed, HoodieTableMetaClient
metaClient, HoodieTableMetadata metadata, Set<String> metadataPartitions) {
+ return computeStats(detailed, metaClient, metadata, metadataPartitions);
Review Comment:
🤖 nit: now that getStats just delegates to computeStats, could this instance
method be dropped and callers point straight at the static one? Keeping both
risks them drifting if one gets updated later.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
