hudi-agent commented on code in PR #20023:
URL: https://github.com/apache/hudi/pull/20023#discussion_r4078389608
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/lsm/TestSpillableLsmRecordIterator.java:
##########
@@ -106,36 +116,97 @@ void testMissingSpillFileIsReportedAsReadFailure() throws
IOException {
iterator.close();
}
- @Test
- void testSuccessfulSpillPropagatesSourceCloseFailure() {
- RuntimeException closeFailure = new RuntimeException("source close
failed");
+ @ParameterizedTest
+ @CsvSource({"false, false", "false, true", "true, false", "true, true"})
+ void testSuccessfulSpillCleansUpOnSourceCloseFailure(boolean empty, boolean
closeError) throws IOException {
Review Comment:
🤖 nit: `empty` and `closeError` are hard to decode at the `@CsvSource` rows
— maybe `emptySource` and `closeThrowsError` (and `sourceCloseFailure(boolean
asError)`) to make the true/false columns self-explanatory?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
